fix(tokens): focus outline in reset.css ontkoppelen van hardcoded waarden#89
Merged
jeffreylauwers merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
…rden Vervang de hardcoded outline-waarden in :focus-visible door de design token variabelen. Dit zorgt ervoor dat de reset consistent is met de focus-tokens en dat componenten zonder eigen focus-styling het correcte design system patroon volgen (dashed, 0px offset, token-kleur). Probleem 2 uit issue #87 (dark mode focus-tokens) was al opgelost in een eerdere sessie — colors-dark.json bevat al een expliciete focus-sectie met afwijkende waarden voor dark mode. Closes #87 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2px solid currentColor/outline-offset: 2pxinreset.cssdoor de design token variabelen--dsn-focus-outline-width,--dsn-focus-outline-style,--dsn-focus-outline-coloren--dsn-focus-outline-offsetdashed,0px offseten de correcte token-kleur — de reset volgt nu dezelfde bron van waarheid als de componenten zelfOpmerking: Probleem 2 uit het issue (dark mode focus-tokens ontbreken) was al opgelost —
colors-dark.jsonbevat al een explicietefocus-sectie met eigen dark mode waarden (#f4f4f4outline, inverse#0b0c0c).Closes #87
Test plan
pnpm test— 1008 tests groenpnpm --filter storybook exec tsc --noEmit— 0 foutenpnpm lint— 0 fouten🤖 Generated with Claude Code